Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit Cargo.lock file #29

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

a-kenji
Copy link
Contributor

@a-kenji a-kenji commented Sep 5, 2024

The Cargo.lock file is recommended to be checked in for executables.
It allows building and installing the application through cargo in a way
that references a common set of dependencies.

This is also important for distributions like Fedora, or NixOs, that use
the cargo vendor command to package the actual version that is
released rather than everyone having a package that can essentialy
behave differently in non obvious ways.

Reference:

The `Cargo.lock` file is recommended to be checked in for executables.
It allows building and installing the application through cargo in a way
that references a common set of dependencies.

This is also important for distributions like Fedora, or NixOs, that use
the `cargo vendor` command to package the actual version that is
released rather than everyone having a package that can essentialy
behave differently in non obvious ways.

Reference:
- https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
@SoptikHa2 SoptikHa2 self-requested a review September 5, 2024 13:35
@SoptikHa2
Copy link
Owner

Looks great, thanks! Should've done this a long time ago

@SoptikHa2 SoptikHa2 merged commit 59c0fa4 into SoptikHa2:master Sep 5, 2024
@a-kenji a-kenji deleted the add/lockfile branch September 5, 2024 13:40
@a-kenji
Copy link
Contributor Author

a-kenji commented Sep 5, 2024

Thank you for being so responsive, this really helps our efforts :).

@a-kenji a-kenji mentioned this pull request Sep 5, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants